Skip to content

feat: multi-arch build support and README updates#5388

Merged
kvenkatachala333 merged 5 commits intoGoogleCloudPlatform:release-candidatefrom
kvenkatachala333:upd_bin_readme
Mar 25, 2026
Merged

feat: multi-arch build support and README updates#5388
kvenkatachala333 merged 5 commits intoGoogleCloudPlatform:release-candidatefrom
kvenkatachala333:upd_bin_readme

Conversation

@kvenkatachala333
Copy link
Copy Markdown
Member

@kvenkatachala333 kvenkatachala333 commented Mar 24, 2026

Description

This PR introduces multi-architecture support for Cluster Toolkit release bundles.

New Naming Convention:
gcluster_bundle_<os>_<arch>.zip

Supported Architectures starting v1.85.0:

  • linux_amd64
  • linux_arm64
  • mac_amd64
  • mac_arm64

@kvenkatachala333 kvenkatachala333 added the release-improvements Added to release notes under the "Improvements" heading. label Mar 24, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Mar 24, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Cluster Toolkit by adding multi-architecture support for its release bundles. This change allows users to download pre-built binaries tailored to specific operating systems and CPU architectures, such as Linux amd64, Linux arm64, macOS amd64, and macOS arm64. The documentation has been thoroughly updated to guide users through the new download process and clarify compatibility, making the toolkit more accessible and easier to set up across a wider range of environments.

Highlights

  • Multi-architecture Build Support: Introduced support for multiple architectures (amd64 and arm64) for both Linux and macOS release bundles, enhancing the toolkit's compatibility across different systems.
  • New Bundle Naming Convention: Implemented a new naming convention for release bundles: gcluster_bundle_<os>_<arch>.zip, to clearly indicate the target operating system and architecture.
  • README Documentation Updates: Updated the README.md file to reflect the new multi-architecture support, including revised download instructions, an updated compatibility matrix, and clarification on version availability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully introduces multi-architecture support for Cluster Toolkit release bundles. The README.md file has been comprehensively updated to reflect these changes, including the new naming convention for bundles, an expanded compatibility matrix for Linux and macOS (covering both amd64 and arm64), and revised download instructions. The added note about multi-architecture builds being available from version 1.85.0 is also a valuable clarification for users. The documentation changes are clear and accurately communicate the new capabilities.

Neelabh94
Neelabh94 requested changes Mar 24, 2026
View reviewed changes
Neelabh94
Neelabh94 previously approved these changes Mar 24, 2026
View reviewed changes
@LAVEEN
Copy link
Copy Markdown
Contributor

LAVEEN commented Mar 24, 2026

For surity , please try and run the binary too on respective archtiecture . Just wanted to make sure its executable on the respective arch.

LAVEEN
LAVEEN previously approved these changes Mar 24, 2026
View reviewed changes
@kvenkatachala333 kvenkatachala333 marked this pull request as ready for review March 25, 2026 05:13
@kvenkatachala333 kvenkatachala333 requested review from a team and samskillman as code owners March 25, 2026 05:13
@kvenkatachala333 kvenkatachala333 changed the base branch from develop to release-candidate March 25, 2026 05:13
@kvenkatachala333 kvenkatachala333 dismissed stale reviews from LAVEEN and Neelabh94 March 25, 2026 05:13

The base branch was changed.

@kvenkatachala333 kvenkatachala333 merged commit eed7b09 into GoogleCloudPlatform:release-candidate Mar 25, 2026
12 of 68 checks passed
@kvenkatachala333 kvenkatachala333 deleted the upd_bin_readme branch March 25, 2026 05:35
FIoannides pushed a commit to FIoannides/cluster-toolkit that referenced this pull request Mar 27, 2026
@kvenkatachala333 @FIoannides
feat: multi-arch build support and README updates (GoogleCloudPlatfor…
93ec6ce 
…m#5388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neelabh94 Neelabh94 Neelabh94 approved these changes

@LAVEEN LAVEEN LAVEEN left review comments

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kvenkatachala333 @LAVEEN @Neelabh94